feat: sync extension bridge settings with cloud #7535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use CloudService.getUserSettings() for remoteControlEnabled instead of global state - Update CloudService.updateUserSettings when toggling remote control - Add BridgeOrchestrator.connectOrDisconnect handling in settings update handler - Remove dependency on contentProxy/globalSettings for remote control state
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| extensionBridgeEnabled: message.bool ?? false, | ||
| }) | ||
| } catch (error) { | ||
| provider.log(`Failed to update cloud settings for remote control: ${error}`) |
Contributor
Author
There was a problem hiding this comment.
When the cloud settings update fails, we're only logging the error. Should we also show a user-facing notification so they know their setting change didn't persist?
Suggested change
| provider.log(`Failed to update cloud settings for remote control: ${error}`) | |
| } catch (error) { | |
| provider.log(`Failed to update cloud settings for remote control: ${error}`) | |
| vscode.window.showErrorMessage('Failed to update remote control setting. Please try again.') | |
| // Don't fall back to local storage - cloud settings are the source of truth | |
| } |
| sessionId: vscode.env.sessionId, | ||
| }) | ||
| } catch (error) { | ||
| cloudLogger( |
Contributor
Author
There was a problem hiding this comment.
Is it intentional that we're not notifying the user when BridgeOrchestrator update fails? The error is logged but users might want to know if their remote control connection has issues.
| settingsUpdatedHandler = postStateListener | ||
|
|
||
| // Enhanced settings updated handler that also updates BridgeOrchestrator | ||
| settingsUpdatedHandler = async () => { |
Contributor
Author
There was a problem hiding this comment.
Consider adding JSDoc comments to document this enhanced settings handler's functionality, especially since it now handles BridgeOrchestrator updates in addition to posting state.
jr
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements cloud-based settings synchronization for the extension bridge feature, replacing local storage with CloudService as requested.
Changes
CloudService.getUserSettings()?.settings?.extensionBridgeEnabledinstead of global state forremoteControlEnabledCloudService.updateUserSettingswhen toggling remote control in the webviewBridgeOrchestrator.connectOrDisconnecthandling in the settings update handlerextensionBridgeEnabledinClineProvider.getState()responseCore Goals Achieved
✅ Don't use contentProxy / globalSettings remoteControlEnabled, use CloudService.instance.getUserSettings()?.settings?.extensionBridgeEnabled
✅ Use CloudService.instance.updateUserSettings to update extensionBridgeEnabled as part of handling the "remoteControlEnabled" webview message
✅ Include CloudService.instance.getUserSettings()?.settings?.extensionBridgeEnabled in the ClineProvider.getState() response under the remoteControlEnabled property
✅ Update BridgeOrchestrator using connectOrDisconnect when cloud user settings change
Testing
Reference
Based on commit dace718 (jr/cloud-control-sync) but using the new BridgeOrchestrator class as requested.
Important
This PR syncs the extension bridge settings with the cloud, replacing local storage with
CloudServicefor managingextensionBridgeEnabledand updating related components accordingly.remoteControlEnabledwithCloudService.getUserSettings()?.settings?.extensionBridgeEnabledinClineProvider.tsandwebviewMessageHandler.ts.CloudService.updateUserSettingswhen toggling remote control in the webview.BridgeOrchestrator.connectOrDisconnectinextension.tsandClineProvider.tsto handle cloud settings changes.extensionBridgeEnabledinClineProvider.getState()response.settingsUpdatedHandlerinextension.tsto reflect cloud settings changes.ClineProvider.tsandwebviewMessageHandler.ts.This description was created by
for c512344. You can customize this summary. It will automatically update as commits are pushed.